fix(client): use ".default" named export when importing axios#1407
Open
tusharf5 wants to merge 1 commit intosendgrid:mainfrom
Open
fix(client): use ".default" named export when importing axios#1407tusharf5 wants to merge 1 commit intosendgrid:mainfrom
tusharf5 wants to merge 1 commit intosendgrid:mainfrom
Conversation
tusharf5
changed the title
|
+1 |
|
Hey @tusharf5, thanks for this. Meanwhile have you found any alternative to solve this without downgrading to < 1? |
Author
|
We use patch-package to update the package @naeemdadi-kunai 
|
Thank you @tusharf5, this is really helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this package with the latest axios with webpack results in an error, using a
.defaultimport which is officially supported by axios fixes that issue.For more context, we are using sendgrid heavily at our org (tens of millions of emails per month) and upgrading to axios > 0 broke sendgrid and we narrowed it down to the import statement that's changed in this PR.
Checklist
If you have questions, please file a support ticket.